OBPIH-7029: add deactivation of receiving bin to receiving tests#66
Merged
alannadolny merged 4 commits intomainfrom Nov 26, 2025
Merged
OBPIH-7029: add deactivation of receiving bin to receiving tests#66alannadolny merged 4 commits intomainfrom
alannadolny merged 4 commits intomainfrom
Conversation
alannadolny
reviewed
Oct 31, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds cleanup logic to deactivate receiving bin locations created during test execution across multiple receiving test files. The change aims to prevent accumulation of bin locations in the test environment.
- Adds
AppConfigimport to access receiving bin prefix configuration - Adds "Deactivate receiving bin" cleanup step to
afterEachhooks in test files - Fixes minor formatting and spelling issues in existing code
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| validationsOnEditAndReceive.test.ts | Splits test suite, adds bin deactivation to second suite, restructures test for "Receive from different locations" |
| validationsOnDeliverOnDate.test.ts | Adds bin deactivation step to afterEach hook |
| tableShortcutsInReceiving.test.ts | Adds bin deactivation step, fixes trailing whitespace formatting issues |
| sortByAlphabeticalOrderAndRemainInputs.test.ts | Adds bin deactivation step to afterEach hook |
| rollbackStatusChanges.test.ts | Adds bin deactivation step to afterEach hook |
| receivingStatusChanges.test.ts | Adds bin deactivation step to afterEach hook |
| receiveToHoldBin.test.ts | Moves variable declarations, adds bin deactivation step, fixes "Deatitave" typo |
| receiveInbound.test.ts | Adds bin deactivation step, restructures nested test suite |
| lotExpirySystemUpdateOnReceiving.test.ts | Adds bin deactivation step within while loop in afterEach |
| importReceivingTemplate.test.ts | Adds bin deactivation step, fixes formatting in template population |
| exportReceivingTemplate.test.ts | Adds bin deactivation step, fixes trailing comma |
| editsInReceiving.test.ts | Adds bin deactivation step to afterEach hook |
| editOriginalLineQtyTo0.test.ts | Adds bin deactivation step to both test suites |
| editBinLocationWhenReceive.test.ts | Moves variable declarations, adds bin deactivation to three test suites |
| cancelRemainingQty.test.ts | Adds bin deactivation step with trailing whitespace |
| assertRecipientField.test.ts | Adds bin deactivation step to afterEach hook |
| assertQtyInputs.test.ts | Adds bin deactivation step to afterEach hook |
| assertCreationOfReceivingBin.test.ts | Adds bin deactivation step to afterEach hook |
| assertCreationOfGoodsReceiptNote.test.ts | Adds bin deactivation step with trailing whitespace |
| assertBinLocationField.test.ts | Adds bin deactivation step, fixes indentation and typo in step description |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kkrawczyk123
force-pushed
the
OBPIH-7029
branch
from
23e6911 to
1361c19
Compare
alannadolny
approved these changes
Nov 26, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
alannadolny
reviewed
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add deactivation of receiving bin to receiving tests to limit the number of created bin locations